Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sync gigasecond #810

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

ahans
Copy link
Contributor

@ahans ahans commented Feb 16, 2024

No description provided.

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 16, 2024
@ahans
Copy link
Contributor Author

ahans commented Feb 16, 2024

@exercism/cpp here is the new PR. I had forced-pushed to the previous to include the no important files changed tag. I wasn't aware that this would prevent re-opening. Sorry about that!

@SleeplessByte SleeplessByte reopened this Feb 16, 2024
@SleeplessByte
Copy link
Member

SleeplessByte commented Feb 16, 2024

The failed check says:

This PR touches files which potentially affect the outcome of 
the tests of an exercise. This will cause all students' solutions
to affected exercises to be re-tested.

If this PR does **not** affect the result of the test (or, for
example, adds an edge case that is not worth rerunning all tests
for), **please add the following to the merge-commit message**
which will stops student's tests from re-running. Please
copy-paste to avoid typos.

```
[no important files changed]
```

For more information, refer to the [documentation](https://exercism.org/docs/building/tracks#h-avoiding-triggering-unnecessary-test-runs). 
If you are unsure whether to add the message or not, please ping
`@exercism/maintainers-admin` in a comment. Thank you!

In this case ya probably want to re-run all the student solutions.

@ahans
Copy link
Contributor Author

ahans commented Feb 16, 2024

In this case ya probably want to re-run all the student solutions.

I only added that one excluded test to tests.toml and renamed the tests. I didn't change any actual test code. The changes there are only formatting (looks like .clang-format has changed in the meantime or hadn't been applied to that file before). So I'm not sure we should really re-run all student solutions. However, I can of course drop the tag. Let me know what to do!

[no important files changed]
@ahans ahans force-pushed the feature/sync-gigasecond branch from 41c5f02 to b503b77 Compare February 16, 2024 18:56
@SleeplessByte
Copy link
Member

I didn't see the include false on the last line. If no tests were added (or changed) then indeed, it should NOT re-run ;)

[fcec307c-7529-49ab-b0fe-20309197618a]
description = "does not mutate the input"
include = false

Copy link
Contributor

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vaeng vaeng merged commit cdaf146 into exercism:main Feb 20, 2024
8 checks passed
@vaeng vaeng mentioned this pull request Feb 26, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants