Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync hamming tests to problem-description data (#775) #789

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

ahans
Copy link
Contributor

@ahans ahans commented Jan 29, 2024

As discussed in #784, I was also confused about the include = false lines. The way I understand it, in canonical-data.json test cases are updated by adding a new version and a reimplements field that references the old version in the file. The old version is left untouched. I can imagine this is done to better be able to follow the edit history. But this also means that obsolete tests should not be part of the implementation. So that is what I have done here.

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 29, 2024
@ahans ahans mentioned this pull request Jan 29, 2024
21 tasks
@vaeng vaeng reopened this Jan 29, 2024
@vaeng
Copy link
Contributor

vaeng commented Jan 29, 2024

We can surely discuss this on the forums. Please note, that it would be better to have uuids as well in the test.cpp file, so they are easier to compare.

@ahans
Copy link
Contributor Author

ahans commented Jan 29, 2024

We can surely discuss this on the forums. Please note, that it would be better to have uuids as well in the test.cpp file, so they are easier to compare.

I added a comment with the UUID before each test case (there were none before). What else did you have in mind?

Update: Alright, I just saw the updated comments for anagram and that tags are used there. That's certainly better. I will adopt the same format here.

@ahans ahans force-pushed the feature/sync-hamming branch from de48277 to 4d89ef9 Compare January 29, 2024 14:15
@ahans
Copy link
Contributor Author

ahans commented Jan 29, 2024

This has been updated.

@vaeng vaeng merged commit 775c6c0 into exercism:main Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants