feat: add tbb and testing to container #84
+15,058
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
approved these changes
May 14, 2024
I will have a look later this week! |
ahans
approved these changes
May 18, 2024
Comment on lines
+47
to
+50
| find_package(TBB) | ||
| if (${TBB_FOUND}) | ||
| target_link_libraries(${exercise} PRIVATE TBB::tbb) | ||
| endif() |
There was a problem hiding this comment.
I think it's appropriate to REQUIRE TBB here:
Suggested change
| find_package(TBB) | |
| if (${TBB_FOUND}) | |
| target_link_libraries(${exercise} PRIVATE TBB::tbb) | |
| endif() | |
| find_package(TBB REQUIRED) | |
| target_link_libraries(${exercise} PRIVATE TBB::tbb) |
We may want to edit the exercise over in cpp to also REQUIRE TBB now. In addition to the CMakeLists.txt, the documentation would also need an update then.
|
Looks like CI is failing |
Because I left some unused variables around. Now it is fine to merge. |
|
@vaeng Let's get someone from the @exercism/guardians team to approve then |
IsaacG
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion on the forums, I added the tbb library to the container and wrote a small (very basic) test to check if it is working as intended.
I'd like to have the opinion of @ahans as well, as they suggested adding it if I remember correctly.