fetch-configlet: support more platforms #809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee7
commented
Aug 22, 2023
Comment on lines
+29
to
+30
| aarch64|arm64) arch='arm64' ;; | ||
| x86_64) arch='x86-64' ;; |
There was a problem hiding this comment.
Suggested change
| aarch64|arm64) arch='arm64' ;; | |
| x86_64) arch='x86-64' ;; | |
| aarch64|arm64) arch='arm64' ;; | |
| arm*) arch='arm' ;; | |
| x86_64) arch='x86-64' ;; |
Maybe.
ErikSchierboom
approved these changes
Aug 22, 2023
ee7
force-pushed
the
fetch-configlet-more-platforms
branch
from
e2f9960
to
13bb39c
Compare
For example, this would work for these `uname -s` outputs: - FreeBSD - NetBSD - OpenBSD
Configlet may never have releases for these. But it's one of the main remaining architecture names that we'd upload with different names than the `uname -m` output. Add support for them now, to avoid an extra Exercism-wide PR for the fetch scripts later.
ee7
force-pushed
the
fetch-configlet-more-platforms
branch
from
13bb39c
to
b3d4707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
fetch-configletto:Working towards my suggestion in #805: