Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GoReleaser config, updated docs, made archive naming adjustments #886

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

ekingery
Copy link
Contributor

@ekingery ekingery commented Oct 8, 2019

This PR adds support for using GoReleaser and closes #700. Additional information on the transition to GoReleaser and adding Snap support for Linux is available here: https://gist.github.com/ekingery/4732af2a828d5992b1cc69d07c87778d

For reference, you can find a test release on my fork: https://github.com/ekingery/cli/releases/tag/v3.0.38

@kytrinyx kytrinyx self-requested a review October 9, 2019 21:02
Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you so much for taking the time to work through this whole process.

Would you mind rebasing onto master and editing the commit to run gofmt on it?

@ekingery ekingery force-pushed the master branch 4 times, most recently from e277b13 to 4debb17 Compare October 10, 2019 03:22
@ekingery
Copy link
Contributor Author

This looks good! Thank you so much for taking the time to work through this whole process.

Would you mind rebasing onto master and editing the commit to run gofmt on it?

Absolutely. This is done and the build is passing. The rebase got a little messy but I think everything looks OK now.

@kytrinyx kytrinyx merged commit b6f0cc2 into exercism:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release tarballs are named ambiguously
2 participants