Extract logic for the URI variable identifying the exercise to download #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. Totally missed a spot here. Ignore this. |
There is very likely a better abstraction hiding close by. This is a minimal, cohesive change, which I think is fairly uncontroversial. If we do find the better abstraction, it's likely that we'll be able to move this one to it wholesale. I've left a bit of duplication in place for now, rather than make a big guess about the abstraction.
kytrinyx
force-pushed
the
download-identifier
branch
from
0bb7a48 to
7c6cd9d
Compare
|
Ok, tried again. I'll merge this when it goes green so that I can keep chipping away at the download command refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is very likely a better abstraction hiding close by.
This is a minimal, cohesive change, which I think is fairly uncontroversial.
If we do find the better abstraction, it's likely that we'll be able to move this one to it wholesale.
I've left a bit of duplication in place for now, rather than make a big guess about the abstraction.