Submit handles non 2xx responses #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdsutherland
commented
Jan 11, 2019
cmd/submit.go
Outdated
| @@ -261,6 +261,10 @@ func (s *submitCmdContext) submit(metadata *workspace.ExerciseMetadata, docs []w | |||
| return fmt.Errorf(jsonErrBody.Error.Message) | |||
| } | |||
|
|
|||
| if resp.StatusCode < 200 || resp.StatusCode > 299 { | |||
| return fmt.Errorf("submission unsuccessful (%s)", resp.Status) | |||
There was a problem hiding this comment.
I'm guessing we want this to be more useful; what should this say?
There was a problem hiding this comment.
The API should respond with {"error": {"type": "some_value", "message": "A human-readable message"}} in the case of an error. Let's use the message if it has something available in it, otherwise let's use the default that you have here.
There was a problem hiding this comment.
Actually, you wrote code that fixed it. I've extracted that here:
#814
jdsutherland
force-pushed
the
submit-handles-non2xx
branch
2 times, most recently
from
8f6551f to
4b23582
Compare
|
@jdsutherland Now that we've gotten some of the helpers into master, would it make sense to rework this to use the helpers? |
jdsutherland
force-pushed
the
submit-handles-non2xx
branch
2 times, most recently
from
1c3d8a9 to
4b23582
Compare
Previously, 404s silently continue to misleading success output
jdsutherland
force-pushed
the
submit-handles-non2xx
branch
from
4b23582 to
10aea95
Compare
|
This is ready for another look. |
kytrinyx
approved these changes
Mar 8, 2019
| @@ -611,6 +611,44 @@ func TestSubmitServerErr(t *testing.T) { | |||
| assert.Regexp(t, "test error", err.Error()) | |||
| } | |||
|
|
|||
| func TestHandleErrorResponse(t *testing.T) { | |||
There was a problem hiding this comment.
Thank you for adding this test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, 404s silently continue to misleading success output. This change throws an error for all non 2xx responses.
Closes #790.