Fix test failure panics when err is nil #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently several tests use `assert.Regexp(.. err.Error())` where err is unchecked. If there is no error (it's nil) then the tests blow up and we don't get a useful failure.
jdsutherland
force-pushed
the
fix-test-err-nil-panics
branch
from
67be838 to
85e2be2
Compare
nywilken
approved these changes
Dec 9, 2018
Smarticles101
pushed a commit
to Smarticles101/cli
that referenced
this pull request
Feb 28, 2019
Currently several tests use `assert.Regexp(.. err.Error())` where err is unchecked. If there is no error (it's nil) then the tests blow up and we don't get a useful failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently several tests use
assert.Regexp(.. err.Error())where err isunchecked. If there is no error (it's nil) then the tests blow up and we
don't get a useful failure message.