Exercise dirname matches metadata exercise slug #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdsutherland
force-pushed
the
ensure-exercise-dirname-matches-metadata-slug
branch
from
64654f9 to
7c16f08
Compare
jdsutherland
force-pushed
the
ensure-exercise-dirname-matches-metadata-slug
branch
from
7c16f08 to
91fad9a
Compare
jdsutherland
force-pushed
the
ensure-exercise-dirname-matches-metadata-slug
branch
from
1edcfe0 to
5ae41df
Compare
nywilken
reviewed
Dec 9, 2018
cmd/submit.go
Outdated
| @@ -141,6 +141,11 @@ func runSubmit(cfg config.Config, flags *pflag.FlagSet, args []string) error { | |||
| return err | |||
| } | |||
|
|
|||
| if exercise.Slug != metadata.Exercise { | |||
| // TODO: error msg should suggest running future doctor command | |||
| return errors.New("exercise directory does not match exercise slug in metadata") | |||
There was a problem hiding this comment.
Maybe we should indicate what was found, what was expected, and how to fix. When users open issues pertaining to path errors the messaging doesn't contain path information, which makes the troubleshooting a little harder than it needs to be.
exercise directory does not match slug: expected %s but found %s. Please rename the directory and try again.
jdsutherland
force-pushed
the
ensure-exercise-dirname-matches-metadata-slug
branch
from
72c54cc to
fb46844
Compare
jdsutherland
force-pushed
the
ensure-exercise-dirname-matches-metadata-slug
branch
from
fb46844 to
485caf7
Compare
Smarticles101
approved these changes
Dec 11, 2018
|
@jdsutherland thanks for making the updates. @Smarticles101 thanks for reviewing as well. |
nywilken
approved these changes
Dec 12, 2018
jdsutherland
added a commit
to jdsutherland/cli
that referenced
this pull request
Dec 12, 2018
* Exercise dirname matches metadata exercise slug * Avoid panic when err nil on test failure * Make error message actionable
Smarticles101
pushed a commit
to Smarticles101/cli
that referenced
this pull request
Feb 28, 2019
* Exercise dirname matches metadata exercise slug * Avoid panic when err nil on test failure * Make error message actionable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #773