Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max allowed file size error to include filename #739

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Sep 19, 2018

Currently when submitting a file that is larger than the max allowed size the user receives an error indicating that a submitted file is larger than the max allowed file size, but it does not include the actual name of the file.

This is not really an issue when submitting a single file, but when a user submits two or more files the error message is a bit of a guessing game.

@nywilken nywilken changed the title Update MaxFileSize error to include filename Update max allowed file size error to include filename Sep 19, 2018
@nywilken nywilken force-pushed the enormous-file-message branch from bb9140b to e58f35b Compare September 19, 2018 02:21
Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch, thank you!

@nywilken
Copy link
Contributor Author

Thanks for the review.

@nywilken nywilken merged commit 39ec866 into exercism:master Sep 22, 2018
@nywilken nywilken deleted the enormous-file-message branch September 22, 2018 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants