Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug API call timing. #271

Merged
merged 1 commit into from
Jan 13, 2016
Merged

Add debug API call timing. #271

merged 1 commit into from
Jan 13, 2016

Conversation

Tonkpils
Copy link
Contributor

Also, increased the timeout to 20 seconds which gives slow clients a bit more time to complete the calls

Fixes #268

Any feedback on this would be great. It's a bit of a mess since I added a lot of code to handle concurrent API ping checks. We are also checking against Github's API to ensure it's not just our API that is timing out.

The output of the command now looks like this:

**** Debug Information ****
Exercism CLI Version: 2.2.3
Exercism CLI Latest Release: 2.2.3
OS/Architecture: darwin/amd64
Build OS/Architecture /
Home Dir: /Users/leo
Config file: /Users/leo/.exercism.json
API Key: 888c953db23817e4db310f10bf476222af806cc9
Exercises Directory: /Users/leo/code/exercisms
Testing API endpoints reachability
    * GitHub API: https://api.github.com/ [connected] 287.315532ms
    * XAPI: http://x.exercism.io [connected] 575.072309ms
    * API: http://exercism.io [connected] 863.000295ms

If you are having trouble and need to file a GitHub issue (https://github.com/exercism/exercism.io/issues) please include this information (except your API key. Keep that private).

Also, increased the timeout to 20 seconds which gives slow clients a bit more time to complete the calls
@kytrinyx
Copy link
Member

+1 on both increasing the timeout, and checking against GitHub's API. I also like getting more data out of the ping.

LGTM!

kytrinyx added a commit that referenced this pull request Jan 13, 2016
@kytrinyx kytrinyx merged commit 51c4967 into master Jan 13, 2016
@kytrinyx kytrinyx deleted the debug-timing branch January 13, 2016 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants