Better error message when track/problem can't be identified #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created two error messages for two scenarios.
submit
is called outside of the configured exercises directory, use themsgSubmitCalledFromWrongDir
templatesubmit
is called inside the configured exercises directory, but the path seems weird, usemsgGenericPathError
template. I was able to simulate this error like this:Happy to rework any of this. 🎅 🎄 🎁
I used
text/template
because the messages were quite long. TheiterationError
type is not necessary, strictly speaking, but I'd like to know what the rest of the team thinks.It was mentioned in #197 that we could suggest the proper path. I am unsure how to do that without having some kind of lookup based on file extension and the exercise slug. Even if I know that the file they're trying to submit is JavaScript, how can I tell it's the
hello-world
problem when they're submitting from a bad path/location?