-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add package for logging output #248
Conversation
This will provide us with 2 levels of output, normal output and debugging output. With the Verbose flag enabled, debugging output will also be shown to the user. Once we're happy with how this is looking, I'll integrate it with the rest of the app. |
I think I like where this is going. I'm hesitating over one thing: do we really want to use the log package to tell the user things? That seems like not logging to me. Now that I write it out, it seems like debug info isn't quite logging either, so maybe this is just a question of semantics. |
Semantics are important. The better the naming, the less we have to think when we're reading code. What do you think about changing the package name to
We could also keep the user related output going through the I'm kind of leaning toward the |
Yeah, either of these feel like good approaches to me. I'm with you on leaning a bit towards using I'm thinking the usual stuff would go to STDOUT and the debug stuff would go to STDERR. |
f68b71a
to
833cba9
Compare
This package will print output to StdErr when the verbose flag is set for the cli.
This should now reflect the changes we'd talked about. I've also wired up the verbose flag to activate the debug output. EDIT: something went screwy when I tried to rebase. I'll cherry-pick this commit onto master if this looks good. |
👍 Looks good to me. |
merged e071831 |
No description provided.