avoid ambiguous or unresolvable exercism paths #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update is not guaranteed to work, we should handle any returned errors.
| @@ -22,7 +22,11 @@ func Configure(ctx *cli.Context) { | |||
| host := ctx.String("host") | |||
| dir := ctx.String("dir") | |||
| api := ctx.String("api") | |||
| c.Update(key, host, dir, api) | |||
|
|
|||
| err = c.Update(key, host, dir, api) | |||
There was a problem hiding this comment.
Can we scope this in the if statement like so.
if err := c.Update(...); err != nil {
|
Thanks @Tonkpils - I've implemented your suggestions. |
|
This is a great fix! Thanks! |
Tonkpils
added a commit
that referenced
this pull request
Aug 3, 2015
avoid ambiguous or unresolvable exercism paths
|
+1000! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepend any relative path with the current working directory so the path can be absolute and will be resolvable no matter what directory you're in.
Fixes #205