Upgrade command #196
Merged
Upgrade command #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is so cool! I'm at work, so can't read through it now. I think setting the arm version with a build flag is perfect. |
|
Ok, I re-wrote the |
| @@ -266,6 +266,7 @@ func (c *Client) Tracks() ([]*Track, error) { | |||
| return payload.Tracks, nil | |||
| } | |||
|
|
|||
| // Skip sends a request to exercism to skip the exercise given language and slug | |||
|
This looks great. I'm going to merge it in (the only thing that I was wondering about is a comment, and that can be tweaked later, I think). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working prototype of the
upgradecommand for the CLI.It will install the latest version of the CLI under the same path as the executable that called the command.
One thing that it does not support yet that I'd like to fix before this gets merged:
Golang has no way of checking the ARM version during runtime
-ldflagswhich would allow us to set the binary's OS/ARCH/ARMV that was used during build.Also, I wrote the windows portion a bit blindly since I don't have a windows machine to test it on. I'll make sure it works properly when I get a chance.
I'd also like to include a generic message to file an issue here if the install fails with the
debuginfo but not too sure how the message should read. Thoughts?Once this is merged it fixes #61