Open browser from cli #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 17, 2015 18:28
The command grabs the latest submission for a language exercise combination and opens up in a browser.
|
Works well on OSX. @kytrinyx know anyone that could test this on Windows and Linux? |
|
/cc @jwood803, @LegalizeAdulthood want to give this a shot on windows? I don't know anyone off the top of my head who uses exercism with linux, I'd be willing to hope that it works and then deal with bugfixes later. |
|
Sure, I can try this out this week or so. |
|
@jwood803 Were you able to validate this functionality on Windows? |
|
If not, that's fine. We can release a bugfix if it turns out that there's a problem. I'll give this until tomorrow and then merge. |
|
Merging. I'll put out a release in a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #83 . It's still missing some tests for the new API that I'd like to add.
I'd also like to add unit tests for the new command that was added but I'm not quiet sure how to go about that. Any suggestions?