Clean up API package. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an API Client from the cmd package Have functions form up their own urls and give them parameters they need
|
|
||
| UnknownLanguageError = errors.New("the language is unknown") | ||
| // ErrUnknownLanguage represents an error returned when the language requested does not exist | ||
| ErrUnknownLanguage = errors.New("the language is unknown") |
|
This looks much, much cleaner. I would say go for it. |
|
I'll keep adding tests as I go but the main idea is there. |
|
Awesome! Don't forget to give yourself some credit in the changelog. |
|
I've added an entry to the changelog for this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an API Client from the cmd package
Have functions form up their own urls and give them parameters they need
I wanted to get this proof of concept here to get some feedback. Meanwhile, I'll write some tests around this new structure.