Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in release instructions #1058

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Fix broken links in release instructions #1058

merged 4 commits into from
Oct 4, 2022

Conversation

kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Oct 4, 2022

The GoReleaser docs have changed and they moved the information about the requirements for the GitHub API token as well as about signing releases.

The GoReleaser docs have changed and they moved the information
about the requirements for the GitHub API token as well as
about signing releases.
@kytrinyx kytrinyx requested a review from ekingery October 4, 2022 08:26
@kytrinyx
Copy link
Member Author

kytrinyx commented Oct 4, 2022

Note: I couldn't find a suitable link for https://goreleaser.com/environment/#using-the-main-version (mentioned in the bit about bumping the version number). @ekingery would you be able to figure out where this bit of documentation moved?

Copy link
Contributor

@ekingery ekingery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! I found the main.version link and updated this branch accordingly.

@kytrinyx
Copy link
Member Author

kytrinyx commented Oct 4, 2022

Ah, great find, thank you!

@kytrinyx kytrinyx merged commit c811ef5 into main Oct 4, 2022
@kytrinyx kytrinyx deleted the releases-404 branch October 4, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants