Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ REFACTOR: Replace attrs by dataclasses #557

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

chrisjsewell
Copy link
Member

Removes dependency on attrs

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #557 (8909fb2) into master (719de0a) will decrease coverage by 0.13%.
The diff coverage is 86.86%.

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   89.78%   89.64%   -0.14%     
==========================================
  Files          16       17       +1     
  Lines        2104     2154      +50     
==========================================
+ Hits         1889     1931      +42     
- Misses        215      223       +8     
Flag Coverage Δ
pytests 89.64% <86.86%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/dc_validators.py 84.00% <84.00%> (ø)
myst_parser/main.py 90.97% <89.36%> (ø)
myst_parser/docutils_.py 80.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719de0a...8909fb2. Read the comment docs.

@chrisjsewell chrisjsewell merged commit fff28a4 into master Apr 16, 2022
@chrisjsewell chrisjsewell deleted the attr-to-dataclass branch April 16, 2022 23:49
kaedroho added a commit to kaedroho/wagtail that referenced this pull request Apr 17, 2022
To resolve issue with the removed `attrs` module.

See: executablebooks/MyST-Parser#557
kaedroho added a commit to wagtail/wagtail that referenced this pull request Apr 17, 2022
To resolve issue with the removed `attrs` module.

See: executablebooks/MyST-Parser#557
gasman pushed a commit to wagtail/wagtail that referenced this pull request May 16, 2022
To resolve issue with the removed `attrs` module.

See: executablebooks/MyST-Parser#557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant