Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ UPGRADE: Change Sphinx pinning to allow version 4 #362

Closed
wants to merge 2 commits into from

Conversation

astrojuanlu
Copy link
Contributor

Sphinx 4.0.0b2 beta is out, and it would be great to see if MyST-Parser works with it. I am doing some local tests with https://github.com/poliastro/poliastro/, which uses it.

@welcome
Copy link

welcome bot commented Apr 29, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #362 (981b843) into master (cb0bca0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files          14       14           
  Lines        1833     1833           
=======================================
  Hits         1661     1661           
  Misses        172      172           
Flag Coverage Δ
pytests 90.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0bca0...981b843. Read the comment docs.

@chrisjsewell
Copy link
Member

thanks, but I can say for definite there are things to address like executablebooks/meta#306 (comment)

@astrojuanlu
Copy link
Contributor Author

Woops, I didn't see that discussion, will take a look. Thanks @chrisjsewell!

@jpmckinney
Copy link
Contributor

Can we unpin and later fix mathjax issues? Not everyone who uses MyST-Parser (but who wants to use Sphinx 4) uses mathjax. It can be a minor version to flag that the upgrade isn't seamless.

@chrisjsewell
Copy link
Member

superceded by #390

@astrojuanlu astrojuanlu deleted the sphinx-4 branch June 13, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants