Bump Stripe.net from 47.4.0 to 49.0.0 and fix breaking API changes #1938
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -219,7 +219,13 @@ public async Task<ActionResult<Invoice>> GetInvoiceAsync(string id) | |||||
| { | ||||||
| var client = new StripeClient(_options.StripeOptions.StripeApiKey); | ||||||
| var invoiceService = new InvoiceService(client); | ||||||
|
|
||||||
| // In Stripe.net v48, expand to include all necessary price information | ||||||
| var options = new InvoiceGetOptions | ||||||
| { | ||||||
| Expand = new List<string> { "lines", "lines.data.price" } | ||||||
|
||||||
| }; | ||||||
| stripeInvoice = await invoiceService.GetAsync(id, options); | ||||||
| } | ||||||
| catch (Exception ex) | ||||||
| { | ||||||
|
|
@@ -239,26 +245,102 @@ public async Task<ActionResult<Invoice>> GetInvoiceAsync(string id) | |||||
| OrganizationId = organization.Id, | ||||||
| OrganizationName = organization.Name, | ||||||
| Date = stripeInvoice.Created, | ||||||
| Paid = String.Equals(stripeInvoice.Status, "paid"), | ||||||
| Total = stripeInvoice.Total / 100.0m | ||||||
| }; | ||||||
|
|
||||||
| foreach (var line in stripeInvoice.Lines.Data) | ||||||
| { | ||||||
| var item = new InvoiceLineItem { Amount = line.Amount / 100.0m, Description = line.Description }; | ||||||
|
|
||||||
| // Try to access price information in multiple ways for Stripe.net v48 compatibility | ||||||
| try | ||||||
| { | ||||||
| // First, try the expanded Price property using reflection (safe for v48) | ||||||
| var priceProperty = line.GetType().GetProperty("Price"); | ||||||
| if (priceProperty is not null) | ||||||
| { | ||||||
| var price = priceProperty.GetValue(line); | ||||||
| if (price is not null) | ||||||
| { | ||||||
| var priceIdProperty = price.GetType().GetProperty("Id"); | ||||||
| var nicknameProperty = price.GetType().GetProperty("Nickname"); | ||||||
| var unitAmountProperty = price.GetType().GetProperty("UnitAmount"); | ||||||
| var recurringProperty = price.GetType().GetProperty("Recurring"); | ||||||
|
|
||||||
| if (priceIdProperty is not null) | ||||||
| { | ||||||
| var priceId = priceIdProperty.GetValue(price) as string; | ||||||
| var nickname = nicknameProperty?.GetValue(price) as string; | ||||||
| var unitAmount = unitAmountProperty?.GetValue(price) as long?; | ||||||
|
|
||||||
| string planName = nickname ?? _billingManager.GetBillingPlan(priceId)?.Name ?? priceId ?? "Unknown"; | ||||||
|
|
||||||
| // Get interval from recurring property | ||||||
| string intervalText = "one-time"; | ||||||
| if (recurringProperty is not null) | ||||||
| { | ||||||
| var recurring = recurringProperty.GetValue(price); | ||||||
| if (recurring is not null) | ||||||
| { | ||||||
| var intervalProperty = recurring.GetType().GetProperty("Interval"); | ||||||
| if (intervalProperty is not null) | ||||||
| { | ||||||
| intervalText = intervalProperty.GetValue(recurring) as string ?? "one-time"; | ||||||
| } | ||||||
| } | ||||||
|
||||||
| } | ||||||
|
|
||||||
| var priceAmount = unitAmount.HasValue ? (unitAmount.Value / 100.0) : 0.0; | ||||||
| item.Description = $"Exceptionless - {planName} Plan ({priceAmount:c}/{intervalText})"; | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| else | ||||||
| { | ||||||
| // Fallback: Try to access through Plan property (legacy support) | ||||||
| var planProperty = line.GetType().GetProperty("Plan"); | ||||||
| if (planProperty is not null) | ||||||
| { | ||||||
| var plan = planProperty.GetValue(line); | ||||||
| if (plan is not null) | ||||||
| { | ||||||
| var planIdProperty = plan.GetType().GetProperty("Id"); | ||||||
| if (planIdProperty is not null) | ||||||
| { | ||||||
| var priceId = planIdProperty.GetValue(plan) as string; | ||||||
| if (!String.IsNullOrEmpty(priceId)) | ||||||
| { | ||||||
| var billingPlan = _billingManager.GetBillingPlan(priceId); | ||||||
| if (billingPlan is not null) | ||||||
| { | ||||||
| item.Description = $"Exceptionless - {billingPlan.Name} Plan"; | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| catch (Exception ex) | ||||||
| { | ||||||
| _logger.LogWarning(ex, "Failed to process price information for invoice line item"); | ||||||
| // Fall back to original description | ||||||
| } | ||||||
|
|
||||||
| var periodStart = line.Period.Start >= DateTime.MinValue ? line.Period.Start : stripeInvoice.PeriodStart; | ||||||
| var periodEnd = line.Period.End >= DateTime.MinValue ? line.Period.End : stripeInvoice.PeriodEnd; | ||||||
| item.Date = $"{periodStart.ToShortDateString()} - {periodEnd.ToShortDateString()}"; | ||||||
| invoice.Items.Add(item); | ||||||
| } | ||||||
|
|
||||||
| var periodStart = line.Period.Start >= DateTime.MinValue ? line.Period.Start : stripeInvoice.PeriodStart; | ||||||
| var periodEnd = line.Period.End >= DateTime.MinValue ? line.Period.End : stripeInvoice.PeriodEnd; | ||||||
| item.Date = $"{periodStart.ToShortDateString()} - {periodEnd.ToShortDateString()}"; | ||||||
| invoice.Items.Add(item); | ||||||
| } | ||||||
|
|
||||||
| var coupon = stripeInvoice.Discounts?.FirstOrDefault(d => d.Deleted is false)?.Coupon; | ||||||
| if (coupon is not null) | ||||||
| { | ||||||
| if (coupon.AmountOff.HasValue) | ||||||
|
|
@@ -429,15 +511,29 @@ public async Task<ActionResult<ChangePlanResult>> ChangePlanAsync(string id, str | |||||
| var createCustomer = new CustomerCreateOptions | ||||||
| { | ||||||
| Source = stripeToken, | ||||||
| Description = organization.Name, | ||||||
| Email = CurrentUser.EmailAddress | ||||||
| }; | ||||||
|
|
||||||
| var customer = await customerService.CreateAsync(createCustomer); | ||||||
|
|
||||||
| // Create subscription separately since Plan is deprecated in CustomerCreateOptions | ||||||
| var subscriptionCreateOptions = new SubscriptionCreateOptions | ||||||
| { | ||||||
| Customer = customer.Id, | ||||||
| Items = new List<SubscriptionItemOptions> { new SubscriptionItemOptions { Price = planId } } | ||||||
| }; | ||||||
|
|
||||||
| // Apply coupon as discount if provided | ||||||
| if (!String.IsNullOrWhiteSpace(couponId)) | ||||||
| { | ||||||
| subscriptionCreateOptions.Discounts = new List<SubscriptionDiscountOptions> | ||||||
| { | ||||||
| new SubscriptionDiscountOptions { Coupon = couponId } | ||||||
| }; | ||||||
| } | ||||||
|
|
||||||
| await subscriptionService.CreateAsync(subscriptionCreateOptions); | ||||||
|
|
||||||
| organization.BillingStatus = BillingStatus.Active; | ||||||
| organization.RemoveSuspension(); | ||||||
|
|
@@ -446,8 +542,8 @@ public async Task<ActionResult<ChangePlanResult>> ChangePlanAsync(string id, str | |||||
| } | ||||||
| else | ||||||
| { | ||||||
| var update = new SubscriptionUpdateOptions { Items = new List<SubscriptionItemOptions>() }; | ||||||
|
||||||
| var update = new SubscriptionUpdateOptions { Items = new List<SubscriptionItemOptions>() }; | |
| var update = new SubscriptionUpdateOptions { Items = [] }; |
do we even need to initialize Items?
There was a problem hiding this comment.
Simplified to use C# 12 collection expression [] syntax. We do need to initialize Items since we call .Add() on it later (lines 499 and 504). Fixed in 78a8bcf.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to latest version: 49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to Stripe.net v49.0.0 and fixed the breaking API changes. The main change in v49 is that InvoiceLineItem.Price was completely removed - now using Pricing.PriceDetails.Price for the price ID and fetching full Price objects via PriceService. Fixed in ee24f43.