Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDVT tests are failing #74

Closed
kaklakariada opened this issue Dec 11, 2023 · 1 comment · Fixed by #75
Closed

TDVT tests are failing #74

kaklakariada opened this issue Dec 11, 2023 · 1 comment · Fixed by #75
Assignees
Labels
bug Unwanted / harmful behavior

Comments

@kaklakariada
Copy link
Collaborator

The TDVT tests for JDBC connector fail with the following error message in tdvt_log_combined.txt:

2023-12-11 07:55:34,544 Thread-[1] Running test:logical.calcs.exasol_jdbc
2023-12-11 07:55:34,553 Thread-[1]  calling C:\Program Files\Tableau\Tableau 2023.3\bin\tabquerytool.exe --query-file-list C:\Users\chp\AppData\Local\Temp\2\cca01878f059c4e8bf387d353dba092ed4fa2b543a98fa40ee74a993a3q6rpt0\logical_calcs_exasol_jdbc\tests.txt -d C:\Users\chp\git\tableau-connector\tdvt_jdbc\tds\cast_calcs.exasol_jdbc.tds --combined --schema TestV1 --password-file C:\Users\chp\git\tableau-connector\tdvt_jdbc\tds\exasol_jdbc.password --output-dir C:\Users\chp\AppData\Local\Temp\2\cca01878f059c4e8bf387d353dba092ed4fa2b543a98fa40ee74a993a3q6rpt0 -DLogDir=C:\Users\chp\AppData\Local\Temp\2\cca01878f059c4e8bf387d353dba092ed4fa2b543a98fa40ee74a993a3q6rpt0\logical_calcs_exasol_jdbc -DOverride=ProtocolServerNewLog -DConnectPluginsPath=..\src -DLogicalQueryRewriteDisable=Funcall:RewriteConstantFuncall -DInMemoryLogicalCacheDisable
2023-12-11 07:55:47,401 Thread-[1] CalledProcessError: Return code: 12 Attempting to run query...
TableauException: FederatedSubtreeBuilder: Could not determine types for all columns in the relation.
{"relation-conn":"leaf","relation-conn-class":"exasol_jdbc","relation-table":"[TESTV1].[Calcs]","unknown-type-columns":["[bool0_]","[bool1_]","[bool2_]","[bool3_]"]}

Error running query

2023-12-11 07:55:47,402 Thread-[1] Command line output:Attempting to run query...
TableauException: FederatedSubtreeBuilder: Could not determine types for all columns in the relation.
{"relation-conn":"leaf","relation-conn-class":"exasol_jdbc","relation-table":"[TESTV1].[Calcs]","unknown-type-columns":["[bool0_]","[bool1_]","[bool2_]","[bool3_]"]}

Error running query

2023-12-11 07:55:47,412 
Finished tdvt suite [exasol_jdbc]: tested sql [False]: tested tuples [True]: tested error [False]: output dir [C:\Users\chp\AppData\Local\Temp\2\cca01878f059c4e8bf387d353dba092ed4fa2b543a98fa40ee74a993a3q6rpt0]: logical [True]: config file [logical.calcs.exasol_jdbc]: override [-DConnectPluginsPath=..\src]: tds [C:\Users\chp\git\tableau-connector\tdvt_jdbc\tds\cast_calcs.exasol_jdbc.tds]: thread [6]

In total 31 tests fail because of this:

Test Count: 949 tests
        Passed tests: 918
        Failed tests: 31
        Tests run: 949
        Disabled tests: 0
        Skipped tests: 0

TDVT version: 2.7.6
Tableau Desktop version: 2023.3

See question in TDVT repo: tableau/connector-plugin-sdk#1206

@kaklakariada kaklakariada added the bug Unwanted / harmful behavior label Dec 11, 2023
@kaklakariada kaklakariada self-assigned this Dec 11, 2023
@kaklakariada
Copy link
Collaborator Author

After upgrading to the latest TDVT version 2.13.4 three tests for the DATEADD function are failing. Root cause:

  • Test uses a DATEcolumn and adds 1 second/minute/hour
  • Test expects a timestamp with added second/minute/hour
  • Exasol returns a date when adding an INTERVAL, causing the test expectation to fail

Solution: explicitly cast date to timestamp when adding second/minute/hour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant