#793: Added support for Pandas 2 pyarrow dtype columns for emitting data from Python UDFs #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
force-pushed
the
feature/793_update_to_pandas_2
branch
from
1bce18c
to
d01a24f
Compare
…calar with item in test dataframe.py, because asscalar was removed
tkilias
force-pushed
the
feature/793_update_to_pandas_2
branch
from
6e3a5f8
to
0ad7c51
Compare
…h NAN. - Refactor and split Pandas Tests - Add tests for more dtypes to Pandas Tests
…mezone and started to add mixed value/none tests
tkilias
commented
May 24, 2023
tomuben
reviewed
May 29, 2023
tomuben
reviewed
May 29, 2023
tomuben
reviewed
May 29, 2023
tomuben
reviewed
May 29, 2023
tomuben
reviewed
May 29, 2023
| pyValue.reset(PyObject_Str(pyFloat.get())); | ||
| break; | ||
| case SWIGVMContainers::DOUBLE: | ||
| pyValue.reset(pyFloat.release()); |
There was a problem hiding this comment.
The old implementation used also PyFloat_FromDouble().
And if you change this, should you also check for an error like above for the int case?
There was a problem hiding this comment.
ähm, here we don't do any conversion, we only set pyValue to the value of pyFloat. pyValue will be then emitted.
There was a problem hiding this comment.
Created a ticket exasol/script-languages-release#813
tomuben
reviewed
May 29, 2023
tomuben
reviewed
May 29, 2023
tomuben
previously approved these changes
May 31, 2023
tkilias
changed the title
tkilias
changed the title
tkilias
changed the title
tkilias
changed the title
tomuben
approved these changes
Jun 1, 2023
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to exasol/script-languages-release#793
Related to exasol/script-languages-release#796