Skip to content

Conversation

@tomuben
Copy link
Collaborator

@tomuben tomuben commented Aug 26, 2021

No description provided.

fi

bash "$SCRIPT_DIR/exaslct_within_docker_container.sh" "$RUNNER_IMAGE_NAME" "${@}"
[[ "$(uname)" = Darwin ]] && EXEC_SCRIPT=exaslct_within_docker_container_slim.sh || EXEC_SCRIPT=exaslct_within_docker_container.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.

set -euo pipefail

SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")"
[[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.

set -euo pipefail

SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")"
[[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.




[[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.

set -euo pipefail

SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")"
[[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.

exaslct Outdated

SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")"

[[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.

set -euo pipefail

SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")"
[[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.

fi

bash "$SCRIPT_DIR/exaslct_within_docker_container.sh" "$RUNNER_IMAGE_NAME" "${@}"
[[ "$(uname)" = Darwin ]] && EXEC_SCRIPT=exaslct_within_docker_container_slim.sh || EXEC_SCRIPT=exaslct_within_docker_container.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.

Copy link
Collaborator

@tkilias tkilias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments for bugs in if

@tkilias
Copy link
Collaborator

tkilias commented Aug 31, 2021

I think, we need to link from the script-languages repo to the MacOS X limitations.

@tomuben tomuben merged commit f156b5e into main Aug 31, 2021
@tomuben tomuben deleted the feature/#69_create_slim_version_of_exaslct_for_macosx branch August 31, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants