-
Notifications
You must be signed in to change notification settings - Fork 3
#69: Created slim version of exaslct for MacOsX #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#69: Created slim version of exaslct for MacOsX #71
Conversation
| fi | ||
|
|
||
| bash "$SCRIPT_DIR/exaslct_within_docker_container.sh" "$RUNNER_IMAGE_NAME" "${@}" | ||
| [[ "$(uname)" = Darwin ]] && EXEC_SCRIPT=exaslct_within_docker_container_slim.sh || EXEC_SCRIPT=exaslct_within_docker_container.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.
| set -euo pipefail | ||
|
|
||
| SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")" | ||
| [[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.
| set -euo pipefail | ||
|
|
||
| SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")" | ||
| [[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.
|
|
||
|
|
||
|
|
||
| [[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.
| set -euo pipefail | ||
|
|
||
| SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")" | ||
| [[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.
exaslct
Outdated
|
|
||
| SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")" | ||
|
|
||
| [[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.
| set -euo pipefail | ||
|
|
||
| SCRIPT_DIR="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")" | ||
| [[ "$(uname)" = Darwin ]] && rl=greadlink || rl=readlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.
| fi | ||
|
|
||
| bash "$SCRIPT_DIR/exaslct_within_docker_container.sh" "$RUNNER_IMAGE_NAME" "${@}" | ||
| [[ "$(uname)" = Darwin ]] && EXEC_SCRIPT=exaslct_within_docker_container_slim.sh || EXEC_SCRIPT=exaslct_within_docker_container.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if I like this construct. It is shorter than an if, but I feel it has more potential for errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments for bugs in if
starter_scripts/exaslct_within_docker_container_with_container_build.sh
Outdated
Show resolved
Hide resolved
starter_scripts/exaslct_within_docker_container_without_container_build.sh
Outdated
Show resolved
Hide resolved
|
I think, we need to link from the script-languages repo to the MacOS X limitations. |
No description provided.