#60: Show error when upload not successful #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCA: Result of request put function was not evaluated. Solution: Use HttpBasicAuth (which avoids printing the plain password in case of exception) and check return value of request's put method (raise exception if not successful).
tkilias
approved these changes
Jul 20, 2021
tomuben
deleted the
bug/#60_upload_does_not_show_error_when_not_successful
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA:
Result of request put function was not evaluated.
Solution:
Use HttpBasicAuth (which avoids printing the plain password in case of exception)
and check return value of request's put method (raise exception if not successful).