#50: Add CI checks for other operating systems #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is clear why the test don't work at the moment. You mount the host directory to a different path in the CentOS container. You need to mount it to the same path as on the host. |
|
Please also check the readme. The prerequisite section got a bit messy in the last PR. |
tkilias
requested changes
Jul 5, 2021
tkilias
reviewed
Jul 6, 2021
ci_tests/Ubuntu18.04/Dockerfile
Outdated
| "deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu \ | ||
| $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null | ||
|
|
||
| RUN apt-get -y update && apt-get -y install docker-ce docker-ce-cli containerd.io |
tkilias
reviewed
Jul 6, 2021
ci_tests/Ubuntu20.04/Dockerfile
Outdated
| "deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu \ | ||
| $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null | ||
|
|
||
| RUN apt-get -y update && apt-get -y install docker-ce docker-ce-cli containerd.io |
tkilias
approved these changes
Jul 6, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.