#70: Optimized logging

.github/workflows/check-api-outdated.yml

@@ -10,8 +10,8 @@ on:
     types: [opened, reopened]
   workflow_dispatch:
   schedule:
-    # “At 4 am on every day.” (https://crontab.guru)
-    - cron: "0 4 * * *"
+    # "At 2 am UTC on every day." (https://crontab.guru)
+    - cron: "0 2 * * *"
 
 jobs:
 

doc/changes/unreleased.md

@@ -3,3 +3,5 @@
 ## Refactorings
 
 * #68: Update to Python 3.10
+* #70: Optimized logging
+* n/a: Changed schedule checking if open api is outdated to 2 am

exasol/saas/client/api_access.py

@@ -64,6 +64,11 @@ class DatabaseStartupFailure(Exception):
     successful.
     """
 
+class DatabaseDeleteTimeout(Exception):
+    """
+    If deletion of a SaaS database instance was requested but during the
+    specified timeout it was still reported in the list of existing databases.
+    """
 
 def create_saas_client(
         host: str,
@@ -212,6 +217,22 @@ def _ignore_failures(self, ignore: bool = False):
         yield self._client
         self._client.raise_on_unexpected_status = before
 
+    def wait_until_deleted(
+            self,
+            database_id: str,
+            timeout: timedelta = timedelta(seconds=1),
+            interval: timedelta = timedelta(minutes=1),
+    ):
+        @retry(wait=wait_fixed(interval), stop=stop_after_delay(timeout))
+        def still_exists() -> bool:
+            result = database_id in self.list_database_ids()
+            if result:
+                raise TryAgain
+            return result
+
+        if still_exists():
+            raise DatabaseDeleteTimeout
+
     def delete_database(self, database_id: str, ignore_failures=False):
         with self._ignore_failures(ignore_failures) as client:
             return delete_database.sync_detailed(
@@ -273,7 +294,7 @@ def wait_until_running(
         def poll_status():
             db = self.get_database(database_id)
             if db.status not in success:
-                print(f'status = {db.status}')
+                LOG.info("- Database status: %s ...", db.status)
                 raise TryAgain
             return db.status
 

test/integration/databases_test.py

@@ -31,6 +31,7 @@ def test_lifecycle(api_access, database_name):
         # delete database and verify database is not listed anymore
         wait_for_delete_clearance(start)
         testee.delete_database(db.id)
+        testee.wait_until_deleted(db.id)
         assert db.id not in testee.list_database_ids()