#14 fixture operational saas database #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsimb
reviewed
May 1, 2024
tomuben
reviewed
May 6, 2024
tomuben
reviewed
May 6, 2024
tkilias
requested changes
May 7, 2024
test/integration/api_access.py
Outdated
| def _timestamp_name() -> str: | ||
| username = getpass.getuser() | ||
| timestamp = f'{datetime.now().timestamp():.0f}' | ||
| return f"{username}-{timestamp}" |
Collaborator
There was a problem hiding this comment.
This still can break for long user names, we need to shorten it differently. Furthermore, we still should mention from where the DB is from. So, mu suggestion would be something like the following
{Timestamp}{project_short_tag}_{username} and this overall string truncated to length
@tomuben what is the max length for the DB name in SaaS
Contributor
There was a problem hiding this comment.
input_parameter_limits = {
"max_database_name_length": 20, # in characters
"max_cluster_name_length": 40, # in characters
"autostop_min_idle_time": 15, # in minutes
"autostop_max_idle_time": 10000, # in minutes
"autostop_default_idle_time": 120,
}
Collaborator
There was a problem hiding this comment.
@ckunki maybe we put the unshortened name as main cluster name
Collaborator
Author
There was a problem hiding this comment.
On the other hand, I wonder if the user name is helpful in CI builds.
Collaborator
There was a problem hiding this comment.
I think, the user name was runner, this would indicate the CI
tkilias
reviewed
May 7, 2024
tkilias
requested changes
May 7, 2024
tkilias
reviewed
May 8, 2024
tkilias
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14