Skip to content

Conversation

@Jannis-Mittenzwei
Copy link
Contributor

closes #74

@Jannis-Mittenzwei Jannis-Mittenzwei added the feature Product feature label Jun 20, 2024
@Jannis-Mittenzwei Jannis-Mittenzwei self-assigned this Jun 20, 2024
ckunki
ckunki previously requested changes Aug 2, 2024
Copy link
Contributor

@Nicoretti Nicoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could add some basic information regarding the security linter to the doc e.g. where to configure the output ...

@Nicoretti Nicoretti requested review from Nicoretti and ckunki August 5, 2024 07:33
Nicoretti
Nicoretti previously approved these changes Sep 2, 2024
@ckunki
Copy link
Contributor

ckunki commented Sep 23, 2024

Today I had the opportunity together with @Nicoretti to take a look at your PR.
Nico and I are aware of some changes described in issue #181.
And we propose to wait until #181 is implemented before finalizing the current PR.

@ckunki ckunki dismissed their stale review September 23, 2024 11:56

outdated

Copy link
Contributor

@Nicoretti Nicoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Jannis-Mittenzwei Jannis-Mittenzwei merged commit c922bc2 into main Sep 25, 2024
@Jannis-Mittenzwei Jannis-Mittenzwei deleted the feature#74-add-security-linter-to-the-toolbox branch September 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Add security linter to the toolbox

4 participants