Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucketfs putfile issue on SaaS v2 (python-toolbox 0.18) #148

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

Shmuma
Copy link
Contributor

@Shmuma Shmuma commented Dec 18, 2024

Closes #129

  • implement fix
  • upgrade exasol-toolbox
  • integration test for SaaSBucket issue

After couple of attempts to upgrade to the latest exasol-toolbox (which requires major workflows update), decided to upgrade to the previous version (0.19) and keep workflows.

Workflows should be done in a separate ticket.

@Shmuma Shmuma changed the title Fix bucketfs putfile issue on SaaS v2 (without workflows update) Fix bucketfs putfile issue on SaaS v2 (python-toolbox 0.18) Dec 18, 2024
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved

- name: Build Documentation
run: |
poetry run python -m nox -s build-docs
poetry run nox -s docs:multiversion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you haven't used multi version before you likely miss a configuration bit, see here:
https://exasol.github.io/python-toolbox/0.20.0/faq.html#warning-while-building-multiversion-documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why it generated docs:multiversion. On subsequent tbx workflow update it was just docs:build (which worked fine)

@Shmuma Shmuma temporarily deployed to manual-approval December 18, 2024 13:47 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 18, 2024 14:35 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 18, 2024 14:37 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 18, 2024 16:46 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 19, 2024 11:06 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 19, 2024 11:32 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 19, 2024 12:11 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 19, 2024 17:20 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 20, 2024 10:05 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 20, 2024 10:10 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 20, 2024 11:57 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 23, 2024 12:37 — with GitHub Actions Inactive
@Shmuma Shmuma temporarily deployed to manual-approval December 23, 2024 13:48 — with GitHub Actions Inactive
@Shmuma Shmuma deployed to manual-approval December 23, 2024 13:58 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pytest-backend-plugin to test against SaaS and on-prem and fix putfile SaaS bug
2 participants