Fixed env variable LOG_ENV_VARIABLE_NAME #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
reviewed
Jul 10, 2023
exasol_integration_test_docker_environment/lib/base/luigi_log_config.py
Outdated
Show resolved
Hide resolved
tkilias
requested changes
Jul 10, 2023
tkilias
reviewed
Jul 10, 2023
tkilias
requested changes
Jul 10, 2023
tkilias
requested changes
Jul 11, 2023
test/unit/matchers.py
Outdated
There was a problem hiding this comment.
I would put these directly into test_env_variable.py, because they are very test specific
test/unit/matchers.py
Outdated
|
|
||
|
|
||
| class UsedLogPath: | ||
| def __init__(self, log_path: Path, task_input_parameter): |
There was a problem hiding this comment.
I think, you could directly fetch these parameters from the task
test/unit/matchers.py
Outdated
| return f"Logging: {used_log_path.task_input_parameter}" in log_content | ||
|
|
||
| def __repr__(self): | ||
| return f"LogPathCorrectnessMatcher({str(self.expected_log_path)})" |
There was a problem hiding this comment.
The representation should be designed in a way, that you can potentially diff them, because they are used in diff in case of a failing assert
test/unit/matchers.py
Outdated
| self.task_input_parameter = task_input_parameter | ||
|
|
||
| def __repr__(self): | ||
| return f"UsedLogPath({str(self.log_path)}, {self.task_input_parameter})" |
There was a problem hiding this comment.
The representation should be designed in a way, that you can potentially diff them, because they are used in diff in case of a failing assert
tkilias
requested changes
Jul 13, 2023
Co-authored-by: Torsten Kilias <[email protected]>
tkilias
reviewed
Jul 13, 2023
Co-authored-by: Torsten Kilias <[email protected]>
tkilias
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
[run all tests]to the commit messagefixes #359
fixes #322