Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run evm2wasm tests using runevm #375

Merged
merged 1 commit into from
May 2, 2019
Merged

Run evm2wasm tests using runevm #375

merged 1 commit into from
May 2, 2019

Conversation

axic
Copy link
Member

@axic axic commented Aug 27, 2018

Depends on #288, #513. Depends on releasing runevm.

@axic axic force-pushed the runevm branch 6 times, most recently from 1dd6fce to e008c45 Compare August 28, 2018 21:55
circle.yml Outdated Show resolved Hide resolved
@axic axic force-pushed the runevm branch 2 times, most recently from 278e693 to 7424098 Compare September 18, 2018 01:00
@axic
Copy link
Member Author

axic commented Sep 18, 2018

I'm not sure for what case testeth prints this:

testeth 1.4.0rc7
terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::program_options::validation_error> >'
  what():  the argument for option '--vm' is invalid
/bin/bash: line 3:  2144 Aborted                 testeth -t GeneralStateTests/stExample -- --testpath tests --vm ~/build/src/libhera.so --singlenet Byzantium --singletest "add11" --evmc evm1mode=evm2wasm --evmc sys:evm2wasm=/tmp/runevm.wasm
Exited with code 134

@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #375 into master will decrease coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   51.86%   51.04%   -0.82%     
==========================================
  Files           8        8              
  Lines        1342     1342              
  Branches      130      130              
==========================================
- Hits          696      685      -11     
- Misses        619      630      +11     
  Partials       27       27

@axic
Copy link
Member Author

axic commented Apr 30, 2019

@s1na it seems at least the add11 test is still failing with runevm. Do you have a test case which works?

@s1na
Copy link
Collaborator

s1na commented May 2, 2019

@axic I think it might be due to wasmx/wasm-chisel#85. The runevm release probably doesn't initialize memory. It passes for me locally (I build runevm and pass it through chisel's master branch)

@axic
Copy link
Member Author

axic commented May 2, 2019

Ah ok, that might be it! Will push a new build of runevm to try.

Can you tell me which tests suites it passes?

@s1na
Copy link
Collaborator

s1na commented May 2, 2019

These should at least pass (possibly some others): stExample, stStackTests, stShift and stCodeSizeLimit

@axic
Copy link
Member Author

axic commented May 2, 2019

@s1na uploaded a version built with latest chisel but it still seems to be failing.

Added you to this repo so you can push to this PR, if you would like to play with it.

@axic axic changed the title [WIP] Run evm2wasm tests using runevm Run evm2wasm tests using runevm May 2, 2019
@axic
Copy link
Member Author

axic commented May 2, 2019

This is working now, by mistake the previous runevm binary didnt had the deployer code.

@axic axic merged commit e2dbd02 into master May 2, 2019
@axic axic deleted the runevm branch May 2, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants