-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run evm2wasm tests using runevm #375
Conversation
1dd6fce
to
e008c45
Compare
278e693
to
7424098
Compare
I'm not sure for what case testeth prints this:
|
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 51.86% 51.04% -0.82%
==========================================
Files 8 8
Lines 1342 1342
Branches 130 130
==========================================
- Hits 696 685 -11
- Misses 619 630 +11
Partials 27 27 |
2379e71
to
36aec36
Compare
@s1na it seems at least the |
@axic I think it might be due to wasmx/wasm-chisel#85. The runevm release probably doesn't initialize memory. It passes for me locally (I build |
Ah ok, that might be it! Will push a new build of runevm to try. Can you tell me which tests suites it passes? |
These should at least pass (possibly some others): |
@s1na uploaded a version built with latest chisel but it still seems to be failing. Added you to this repo so you can push to this PR, if you would like to play with it. |
This is working now, by mistake the previous runevm binary didnt had the deployer code. |
Depends on #288, #513. Depends on releasing runevm.