CMake: enable -Wsign-conversion #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
Aug 20, 2018
| @@ -671,7 +671,7 @@ namespace hera { | |||
| } | |||
|
|
|||
| ensureCondition(gas >= 0, ArgumentOutOfRange, "Negative gas supplied."); | |||
| heraAssert((m_msg.flags & ~EVMC_STATIC) == 0, "Unknown flags not supported."); | |||
| heraAssert((m_msg.flags & ~uint32_t(EVMC_STATIC)) == 0, "Unknown flags not supported."); | |||
There was a problem hiding this comment.
I wish I could specify the type of EVMC_STATIC in EVMC, but this is almost impossible.
chfast
approved these changes
Aug 20, 2018
EVMC_STATIC is an enum, which in many compilers would be treated as a signed type (even though none of the values are negative)
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=======================================
Coverage 67.31% 67.31%
=======================================
Files 5 5
Lines 875 875
Branches 123 123
=======================================
Hits 589 589
Misses 257 257
Partials 29 29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311.
Depends on #332.