Rename externalBalance to getExternalBalance #334
Conversation
| @@ -235,13 +235,13 @@ namespace hera { | |||
| return Literal(); | |||
| } | |||
|
|
|||
| if (import->base == Name("getBalance")) { | |||
| if (import->base == Name("getExternalBalance")) { | |||
There was a problem hiding this comment.
I would rather have things in line with existing naming schemes like RPC.
In that can, getExternal* would become get get*At which, in my opinion, makes more sense upon reading.
There was a problem hiding this comment.
This is in line with the EEI, we've agreed that a complete proposal should be made on the EEI to change all occurences of getExternal.
There was a problem hiding this comment.
Ok the name change should probably be introduced in a later revision, as it would probably break a lot of tests for the current one.
Maybe having multiple aliases for EEI methods would be good for backwards compatibility, at the cost of clarity
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 5 5
Lines 860 860
Branches 122 122
=======================================
Hits 581 581
Misses 251 251
Partials 28 28 |
Counterpart of ewasm/design#120