Code Coverage #310
Code Coverage #310
Conversation
|
Looks like the evm2wasm build get messed up when building inside Aleth. I'm not sure why. Probably the easiest approach would be to enabled |
|
|
||
| set(CMAKE_TOOLCHAIN_FILE ${CMAKE_CURRENT_SOURCE_DIR}/cmake/toolchains/cxx11-pic.cmake CACHE FILEPATH "CMake toolchain file") |
There was a problem hiding this comment.
Ned to remove the extra toolchain file then.
CMakeLists.txt
Outdated
| @@ -19,6 +19,9 @@ endif() | |||
|
|
|||
| project(hera) | |||
|
|
|||
| cable_configure_compiler() | |||
| add_compile_options(-Wno-pedantic -Wno-sign-conversion) | |||
There was a problem hiding this comment.
Does cable adds -Wpedantic so that we need to negative it here?
Any point keeping -Wno-unknown-pragmas?
There was a problem hiding this comment.
Can you remove -Wno-sign-conversion and update evm2wasm?
There was a problem hiding this comment.
The -Wno-sign-conversion is also needed in Hera.
It seems that the better way would be fixing evm2wasm, many of those seem to be actual bugs. In a separate PR we could introduce the warning and fix it. |
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
========================================
Coverage ? 65.7%
========================================
Files ? 5
Lines ? 866
Branches ? 122
========================================
Hits ? 569
Misses ? 268
Partials ? 29 |
|
This is ready. |
| @@ -14,7 +14,8 @@ defaults: | |||
| echo Generator: $GENERATOR | |||
| echo CMake options: $CMAKE_OPTIONS | |||
| $CXX --version | |||
| $CXX --version > compiler.version | |||
| $CXX --version >> toolchain | |||
There was a problem hiding this comment.
Shouldn't the first one be > to clear the file if it exists?
There was a problem hiding this comment.
It could be, but this a CI and we start from clean environment.
| @@ -14,7 +14,8 @@ defaults: | |||
| echo Generator: $GENERATOR | |||
| echo CMake options: $CMAKE_OPTIONS | |||
| $CXX --version | |||
| $CXX --version > compiler.version | |||
| $CXX --version >> toolchain | |||
| echo $GENERATOR >> toolchain | |||
There was a problem hiding this comment.
Also instead could just include the generator checksum in the key separately.
| @@ -224,14 +230,14 @@ jobs: | |||
| - *fetch-tests | |||
| - *test | |||
|
|
|||
| linux-clang-shared-debug: | |||
| linux-gcc-shared-coverage: | |||
There was a problem hiding this comment.
On a second thought, maybe we shouldn't do coverage on debug, because we get the non existant coverage on the debug namespace for which we won't have test anyway.
There was a problem hiding this comment.
- coverage implies build with debugging symbols.
- Checking coverage in release builds is not doable. Let's have a base first, then we can start tweaking the config. There are other ways of dealing with such issues like blacklisting some files.
- Also, I don't think we have a capacity to run debug and coverage builds at the moment.
|
|
||
| set(CMAKE_TOOLCHAIN_FILE ${CMAKE_CURRENT_SOURCE_DIR}/cmake/toolchains/cxx11-pic.cmake CACHE FILEPATH "CMake toolchain file") | ||
| cable_configure_toolchain(DEFAULT cxx11-pic) |
There was a problem hiding this comment.
Isn't this getting the toolchain from cable instead? Seems not since I've removed it from the cmake/toolchains directory and it is failing now.
There was a problem hiding this comment.
I taught Cable to also check ${PROJECT_SOURCE_DIR}/cmake/toolchains dir.
|
@axic, what have you done that it is failing now? |
Closes #309