Fix gas related to CREATE #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrettig
added a commit
to lrettig/tests
that referenced
this pull request
Jun 5, 2018
Update gas calc to match fix in ewasm/hera#250
This was referenced Jun 5, 2018
Closed
lrettig
added a commit
to ewasm/tests
that referenced
this pull request
Jun 8, 2018
Update gas calc to match fix in ewasm/hera#250
Member
Author
|
ewasm/tests#44 was just merged, we should rerun these tests. I get an error saying I can't re-trigger the tests since I don't have write permission. @axic could you please rerun? 🙏 |
Member
|
I don't think it should have all this debugging as the output will go crazy. I'll remove them. Also doesn't compile in release mode. |
axic
reviewed
Jun 11, 2018
src/eei.cpp
Outdated
| // NOTE: this must be declared outside the condition to ensure the memory doesn't go out of scope | ||
| vector<uint8_t> contract_code; | ||
| HERA_DEBUG << "Taking GasSchedule::create" << endl; | ||
| takeInterfaceGas(GasSchedule::create); |
Member
There was a problem hiding this comment.
I don't think this is the correct place. Should be grouped with the other takeInterfaceGas call. Moved.
Member
|
@lrettig have a look if you still ok with version. |
axic
approved these changes
Jun 11, 2018
Member
|
Merging this now because of ewasm/tests#44 every other PR is failing now. |
jakelang
added a commit
that referenced
this pull request
Jun 12, 2018
Merged
jakelang
added a commit
that referenced
this pull request
Jul 16, 2018
jakelang
added a commit
that referenced
this pull request
Jul 17, 2018
jakelang
added a commit
that referenced
this pull request
Jul 27, 2018
jakelang
added a commit
that referenced
this pull request
Jul 29, 2018
hugo-dc
pushed a commit
to ewasm/tests
that referenced
this pull request
Nov 3, 2018
Update gas calc to match fix in ewasm/hera#250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ewasm/tests#44
Take base gas before doing 63/64 calc and refund remaining gas after call.
Also includes a bunch more gas-related debug output and a new debug flag to keep evm2wasm output files around for debugging.