Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AsRef in debug API to be more flexible #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use AsRef in debug API to be more flexible #77

wants to merge 1 commit into from

Conversation

axic
Copy link
Member

@axic axic commented Oct 4, 2019

Should check the generated code if it is any worse.

@axic axic requested a review from jakelang October 4, 2019 01:28
jakelang
jakelang approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@jakelang jakelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but may lead to some code bloat if users have multiple types that are logged with this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelang jakelang jakelang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axic @jakelang