-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync kernel #5
base: master
Are you sure you want to change the base?
sync kernel #5
Conversation
026e3d1
to
c451a7f
Compare
_call (gasHigh, gasLow, addressOffset, valueOffset, dataOffset, dataLength, resultOffset, resultLength, cbIndex) { | ||
// _call (gasHigh, gasLow, addressOffset, valueOffset, dataOffset, dataLength, resultOffset, resultLength, cbIndex) { | ||
// cbIndex was for async method | ||
_call (gasHigh, gasLow, addressOffset, valueOffset, dataOffset, dataLength, resultOffset, resultLength) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this needs to have an underscore prefix because call
is a restricted keyword in es6?
@@ -59,6 +59,7 @@ module.exports = class Interface { | |||
'getBlockGasLimit', | |||
'log', | |||
'create', | |||
'_call', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will make call
available to contracts. is there some code somewhere removing the underscore prefix?
@@ -579,6 +580,7 @@ module.exports = class Interface { | |||
storageStore (keyOffset, valueOffset, cbIndex) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cbIndex
parameter should be removed from all of the async methods.
No description provided.