Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storageStore/storageLoad key/value endianess #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix storageStore/storageLoad key/value endianess #12

wants to merge 1 commit into from

Conversation

hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented May 10, 2018

all vm tests passing in evm2wasm, the problem was the same as in storageStore

@hugo-dc hugo-dc requested a review from cdetrio May 10, 2018 05:17
@axic
Copy link
Member

axic commented May 10, 2018

Actually of the points of U256.fromMemory was to deal with endianness.

@cdetrio
Copy link
Contributor

cdetrio commented May 11, 2018

what axic said, we want to make the change in u256.js. see also #6

@lrettig
Copy link
Member

lrettig commented May 22, 2018

Just tried this change, I'm still seeing some failures:

1..1792
# tests 1792
# pass  1732
# fail  60

@hugo-dc
Copy link
Member Author

hugo-dc commented May 22, 2018

@lrettig I changed u256.js as @axic suggested, right now I have 40+ failing tests still have to figure out what is causing them.

@lrettig
Copy link
Member

lrettig commented May 23, 2018

@hugo-dc is that code in the same branch? If so could you push the change? 🙏

@axic axic removed the in progress label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdetrio cdetrio Awaiting requested review from cdetrio

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugo-dc @axic @cdetrio @lrettig