EEI: clarify return and selfdestruct #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
halt
branch
2 times, most recently
from
8af3ed4
to
4a1dbac
Compare
wanderer
reviewed
Oct 8, 2016
| Halt execution returning output data. | ||
| Set the returning output data for the execution. | ||
|
|
||
| *Note*: multiple invocations will overwrite the previous data. |
There was a problem hiding this comment.
We could make it halt also. Is there a reason to have multiple invocations?
There was a problem hiding this comment.
throw Error('return') I assumed that is the same way we would halt selfDestuct.
There was a problem hiding this comment.
That seems like a bad workaround. I think it is better to make it clear in the interface.
|
@wanderer added clarifications |
|
ok lgmt |
wanderer
approved these changes
Oct 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.