Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include system contracts #45

Merged
merged 1 commit into from
Oct 9, 2016
Merged

Include system contracts #45

merged 1 commit into from
Oct 9, 2016

Conversation

axic
Copy link
Member

@axic axic commented Aug 27, 2016

No description provided.

@axic axic force-pushed the system-contracts branch 2 times, most recently from 8ec6f4d to b4ae9e5 Compare August 27, 2016 01:35

Address: `0x000000000000000000000000000000000000000b`

This is optional. It is provided for pure eWASM VMs to support EVM1 contracts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional is a bit misleading here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? They are optional as in not a mandatory part of a client if it opts to implement EVM1 natively.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but they will still need to implement the logic to run the EVM1 when a call goes to that address.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is related to the precompile and the transcompiler.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine this way now, added the semantics in #54.

@axic axic merged commit 3975ac6 into master Oct 9, 2016
@axic axic deleted the system-contracts branch October 9, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants