Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EEI: Split u256 into bytes32+u256 #148

Merged
merged 1 commit into from
Oct 7, 2018
Merged

EEI: Split u256 into bytes32+u256 #148

merged 1 commit into from
Oct 7, 2018

Conversation

axic
Copy link
Member

@axic axic commented Oct 7, 2018

Resolves #105 (comment)

@axic axic requested review from chfast and jakelang October 7, 2018 22:26
jakelang
jakelang approved these changes Oct 7, 2018
View reviewed changes
Copy link
Member

@jakelang jakelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs a corresponding issue opened on Hera if this is merged.

@axic
Copy link
Member Author

axic commented Oct 7, 2018

also needs a corresponding issue opened on Hera if this is merged.

Hera already does this.

@axic axic merged commit acf2a2a into master Oct 7, 2018
@axic axic deleted the bytes32-u256 branch October 7, 2018 22:48
chfast
chfast reviewed Oct 8, 2018
View reviewed changes
Copy link
Collaborator

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast left review comments

@jakelang jakelang jakelang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axic @chfast @jakelang