Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play-site: Add Game of Life to interact samples #446

Merged
merged 1 commit into from
Sep 22, 2024
Merged

play-site: Add Game of Life to interact samples #446

merged 1 commit into from
Sep 22, 2024

Conversation

camh-
Copy link
Member

@camh- camh- commented Sep 20, 2024

Add an implementation of Conway's Game of Life to the interact
samples. While this is titled "game", it is not really a game so does
not really belong in the games section. It features a few different
modes of interaction, so let's place it there.

Link: https://en.wikipedia.org/wiki/Conway%27s_Game_of_Life

Copy link
Member

@juliaogris juliaogris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads so nice and runs really well, thank you!
I've tried a bit to find anything to improve, but no luck...
My only comment: this is snake_case where we have settled on
camelCase for most samples - but I'm happy to reconsider.

  🐉
    🐉
🐉🐉🐉

Add an implementation of Conway's Game of Life to the interact
samples. While this is titled "game", it is not really a game so does
not really belong in the games section. It features a few different
modes of interaction, so let's place it there.

Note: The Gen-command to update the changed snapshot also changed six
other images, likely due to slight differences in my local setup. I
reverted these six images and the tests still pass.

Gen-command: make snaps USE_DOCKER=1
Link: https://en.wikipedia.org/wiki/Conway%27s_Game_of_Life
@camh-
Copy link
Member Author

camh- commented Sep 22, 2024

My only comment: this is snake_case where we have settled on
camelCase for most samples - but I'm happy to reconsider.

Yeah I meant to change that. For whatever reason I seem to write
snakes when writing evy. Fixed.

@camh- camh- merged commit 56fc99c into main Sep 22, 2024
4 checks passed
@camh- camh- deleted the game-of-life branch September 22, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants