Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labsite: Fix link and mobile layout issues #438

Merged
merged 2 commits into from
Sep 16, 2024
Merged

labsite: Fix link and mobile layout issues #438

merged 2 commits into from
Sep 16, 2024

Conversation

juliaogris
Copy link
Member

@juliaogris juliaogris commented Sep 15, 2024

Fix link and mobile layout issues and lab.evy.dev. The link to the playground
was incorrect in the sidebar (/playground rather than /play), now fixed.

Additionally shared links on mobile didn't work, the output display didn't show.
CSS tweaked for this too.


Test link:
https://lab.evy.dev/#content=H4sIAAAAAAAAAysoyswrUVDySM3JyddRcCpNV1T4MH9i94f5Pf1KXAAmQO5JHQAAAA==
vs
https://lab.evytest.dev/#content=H4sIAAAAAAAAAysoyswrUVDySM3JyddRcCpNV1T4MH9i94f5Pf1KXAAmQO5JHQAAAA==

Fix link to playground, which currently points to:

    https://play.evy.devground/
Fix CSS for lab share links, which currently sets the lab to "1 column"
layout instead of "2 column" (code and output). The bug is
that .container:has(.class1, class2), selects all .containers with
class1 OR class2, but we want class1 AND class2 for 2 column layout.

Test link: https://lab.evy.dev/#content=H4sIAAAAAAAAAysoyswrUVDySM3JyddRcCpNV1T4MH9i94f5Pf1KXAAmQO5JHQAAAA==
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📗

@juliaogris juliaogris merged commit 280d82b into main Sep 16, 2024
4 checks passed
@juliaogris juliaogris deleted the fix-lab branch September 16, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants