labsite: Fix mobile three column layout #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
force-pushed
the
labsite-ux
branch
from
71015f3
to
4b3a952
Compare
juliaogris
force-pushed
the
labsite-ux
branch
from
4b3a952
to
fcd2547
Compare
juliaogris
force-pushed
the
labsite-ux
branch
from
fcd2547
to
6f240d1
Compare
juliaogris
force-pushed
the
labsite-ux
branch
from
6f240d1
to
9adfc0b
Compare
Rework lab CSS for stable columns widths regardless of contents. Use nesting and re-arrange the CSS classes for (hopefully) better readability.
Rework JS/CSS for mobile 3 col layout by adding a notes button in the top right corner on labs only (not playsite). Fix bug for #editor=none&content=... #editor=none&source=.... where the display on playsite and labsite were broken for URL fragment parameter hiding the editor. Update mobile primary button for Code/Run/Stop to have label "Notes" when on output screen and there is only Notes and no Editor visible, e.g. the very first #welcome screen. Remove editor and notes for lab#bounce-show for testing purposes. This commit has been tested and should be tested hand by hand in anger on mobile or with browser dev tools active and small mobile view, where only one column (notes/editor/output) are displayed.
juliaogris
force-pushed
the
labsite-ux
branch
from
9adfc0b
to
a0e5551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tweaks so the three columns
if specified are displayed properly.
Add logic to navigate between them.
I've deployed these changes to https://lab.evytest.dev. Ideally tested manually
on mobile or Browser dev tools with <767px width view / responsive enabled.