labsite: Tweak CSS and scrolling behavior #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix light-theme sample selection, as it hadn't been looked at and wasn't properly styled.
Refactor CSS to use CSS nesting for (hopefully) better readability. Nesting is a newer CSS feature that should make it easier to make out things belonging together. I'm not so sure I'm using it all that well, but I had a mix before and I tried to reduce it. I've also removed a couple of duplicated rules and used ones. This should cleanup commit without any visual changes. Link: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting
camh-
approved these changes
Aug 26, 2024
Improve the scrolling experience on Next button click: We now always scroll the next button to the top of the page with the top edge a little clipped. Smooth scrolling is also enabled, so it should hopefully be more obvious what's going on when clicking on the next button. Unfortunately smooth scrolling doesn't seem to work on my linux machine in Firefox or Chrome, but it seem ok on MacOS and iOS.
juliaogris
force-pushed
the
lab3-tweaks
branch
from
fb3fb7b
to
eeaf7d1
Compare
ok, I've changed it. I only had it that way so it was more obvious what's going on |
That makes sense. If you feel that is needed you can stick with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor labsite CSS to use more modern CSS features, especially nesting.
Finally fix the broken looking light-theme sample selection on the playsite and
labsite.
Tweak the scrolling behavior for Next button clicks: we always scroll to top of
notes section. We also use "smooth" scrolling (rather than immediate jumping to
target), which makes it more obvious what's going on. Tested to work on iOS and
MacOS, Chrome, Safari, Firefox. Unfortunately no dice on my Ubuntu laptop with
Smooth scrolling on any browser 🤷♀.
Link: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting
Deployed at https://lab.evytest.dev