Skip to content

Commit

Permalink
tools: Upgrade Playwright
Browse files Browse the repository at this point in the history
Upgrade Playwright to latest version and slightly updated upgrade docs again
to use node with `--prefix` flag like we did in the previous commit.
Like documented, we ran

    npx --prefix e2e -y npm-check-updates --packageFile e2e/package.json -u
    npm --prefix e2e install
    npx --prefix e2e playwright install

manually upgraded the Docker image used in the Makefile and manually tested
the upgrade with `make e2e USE_DOCKER=1`.
  • Loading branch information
juliaogris committed Aug 24, 2024
1 parent 853dcc6 commit 2c088db
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 28 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ define PLAYWRIGHT_CMD_LOCAL
npx --prefix e2e playwright test --config e2e $(PLAYWRIGHT_ARGS)
endef

PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.46.0-jammy
PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.46.1-jammy
PLAYWRIGHT_CMD_DOCKER = docker run --rm \
--volume $$(pwd):/work/ -w /work/ \
--user $(shell id -u):$(shell id -g) \
Expand Down
7 changes: 3 additions & 4 deletions docs/development/upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,9 @@ We use [Playwright] for automated end-to-end and browser testing.

From the repository root directory run

cd e2e
npx -y npm-check-updates -u
npm install
npx playwright install
npx --prefix e2e -y npm-check-updates --packageFile e2e/package.json -u
npm --prefix e2e install
npx --prefix e2e playwright install

If a new version of Playwright has been installed, also update the Docker image
version of Playwright used in Makefile and on CI.
Expand Down
26 changes: 13 additions & 13 deletions e2e/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions e2e/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": "true",
"devDependencies": {
"@playwright/test": "^1.46.0",
"playwright": "^1.46.0"
"@playwright/test": "^1.46.1",
"playwright": "^1.46.1"
}
}
7 changes: 3 additions & 4 deletions frontend/docs/development/upgrade.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions frontend/docs/development/upgrade.htmlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2c088db

Please sign in to comment.