Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
⏮ e2e: Revert some recent e2e fixes (#421)
Revert some recent e2e fixes around share dialog snapshot tests. Revert the removed pixel difference threshhold in one test. However, the previously added ios tests seem to be ok, so we will leave them in. It is unclear how these tests passed on PR CI and but do not pass on main CI despite 3 re-runs. I somewhat consistently could reproduce the issue locally with: BASEURL='https://evy.dev' make e2e USE_DOCKER=1 Against localhost / without BASEURL the issue never shows up for me even when run with docker. However, I had another unrelated issue show up quite frequently too in the docs tests which seems to be addressed with an extra wait for network idle. I will keep the docs tests fix in place. I also suspected that once tests pass once it is harder to get them to fail again, which would explain why we didn't see the issue on the PR before. I'm not sure if this makes any sense at all. Related-Pull-Request: #420 Related-Commit: b8f0fdf Pull-request: #421
- Loading branch information