Skip to content

Commit

Permalink
⏮ e2e: Revert some recent e2e fixes (#421)
Browse files Browse the repository at this point in the history
Revert some recent e2e fixes around share dialog snapshot tests. Revert the
removed pixel difference threshhold in one test. However, the previously added
ios tests seem to be ok, so we will leave them in.

It is unclear how these tests passed on PR CI and but do not pass on main CI
despite 3 re-runs. I somewhat consistently could reproduce the issue locally
with:

	BASEURL='https://evy.dev' make e2e USE_DOCKER=1

Against localhost / without BASEURL the issue never shows up for me even when
run with docker. However, I had another unrelated issue show up quite
frequently too in the docs tests which seems to be addressed with an extra
wait for network idle. I will keep the docs tests fix in place.

I also suspected that once tests pass once it is harder to get them to fail
again, which would explain why we didn't see the issue on the PR before. I'm
not sure if this makes any sense at all.

Related-Pull-Request: #420
Related-Commit: b8f0fdf
Pull-request: #421
  • Loading branch information
juliaogris authored Aug 24, 2024
1 parent 880955b commit 2222497
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions e2e/docs/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ for (const baseURL of baseURLs) {
await link.hover()
await expect(page).toHaveScreenshot("comment-hover.png", sreenshotOpts)
await link.click()
await page.waitForLoadState("networkidle")
await expect(page).toHaveScreenshot("comment-page.png", sreenshotOpts)
})

Expand Down
2 changes: 1 addition & 1 deletion e2e/play/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ end
}
await page.locator('input[type="text"]').click()
await page.locator('input[type="text"]').press("ArrowRight")
await expect(page).toHaveScreenshot("share-dialog.png")
await expect(page).toHaveScreenshot("share-dialog.png", { maxDiffPixelRatio: 0.01 })
await page.locator("#dialog-share .icon-close").click()
await expect(page).toHaveScreenshot("no-dialog.png")
await page.locator("#hamburger").click()
Expand Down

0 comments on commit 2222497

Please sign in to comment.