Skip to content

refactor(block)!: remove GetLastState from components #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tac0turtle merged 5 commits into from
Dec 12, 2025
Merged

refactor(block)!: remove GetLastState from components #2923

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60c6c0e
refactor: add getters fallback for state
julienrbrt Dec 12, 2025
b64a9a6
no context set prior to Start()
julienrbrt Dec 12, 2025
3797318
better logging
julienrbrt Dec 12, 2025
1c48c16
make GetLastState private and remove copy
julienrbrt Dec 12, 2025
d1be450
fix test
julienrbrt Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion block/internal/executing/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,13 @@ func (e *Executor) GetLastState() types.State {
func (e *Executor) getLastState() types.State {
state := e.lastState.Load()
if state == nil {
return types.State{}
// fallback to store
state, err := e.store.GetState(context.Background())
if err != nil {
e.logger.Warn().Err(err).Msg("failed to get state from store, returning empty state")
return types.State{}
}
e.lastState.Store(&state)
}

return *state
Expand Down
8 changes: 7 additions & 1 deletion block/internal/syncing/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,13 @@ func (s *Syncer) Stop() error {
func (s *Syncer) GetLastState() types.State {
state := s.lastState.Load()
if state == nil {
return types.State{}
// fallback to store
state, err := s.store.GetState(context.Background())
if err != nil {
s.logger.Warn().Err(err).Msg("failed to get state from store, returning empty state")
return types.State{}
}
s.lastState.Store(&state)
}

stateCopy := *state
Expand Down
Loading