Skip to content

chore: minor improvement for docs #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tac0turtle merged 1 commit into from
Dec 11, 2025
Merged

chore: minor improvement for docs #2918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,9 @@ type LogConfig struct {
// P2PConfig contains all peer-to-peer networking configuration parameters
type P2PConfig struct {
ListenAddress string `mapstructure:"listen_address" yaml:"listen_address" comment:"Address to listen for incoming connections (host:port)"`
Peers string `mapstructure:"peers" yaml:"peers" comment:"Comma separated list of peers to connect to"`
BlockedPeers string `mapstructure:"blocked_peers" yaml:"blocked_peers" comment:"Comma separated list of peer IDs to block from connecting"`
AllowedPeers string `mapstructure:"allowed_peers" yaml:"allowed_peers" comment:"Comma separated list of peer IDs to allow connections from"`
Peers string `mapstructure:"peers" yaml:"peers" comment:"Comma-separated list of peers to connect to"`
BlockedPeers string `mapstructure:"blocked_peers" yaml:"blocked_peers" comment:"Comma-separated list of peer IDs to block from connecting"`
AllowedPeers string `mapstructure:"allowed_peers" yaml:"allowed_peers" comment:"Comma-separated list of peer IDs to allow connections from"`
Comment on lines +225 to +227
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for standardizing on 'comma-separated'. For consistency, please also apply this change to the flag descriptions for FlagP2PPeers, FlagP2PBlockedPeers, and FlagP2PAllowedPeers in this file (lines 360, 361, and 362 respectively).

}

// SignerConfig contains all signer configuration parameters
Expand Down
2 changes: 1 addition & 1 deletion pkg/p2p/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ func (c *Client) setupGossiping(ctx context.Context) error {
return nil
}

// parseAddrInfoList parses a comma separated string of multiaddrs into a list of peer.AddrInfo structs
// parseAddrInfoList parses a comma-separated string of multiaddrs into a list of peer.AddrInfo structs
func (c *Client) parseAddrInfoList(addrInfoStr string) []peer.AddrInfo {
if len(addrInfoStr) == 0 {
return []peer.AddrInfo{}
Expand Down
2 changes: 1 addition & 1 deletion types/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type State struct {
LastHeaderHash Hash

// DAHeight identifies DA block containing the latest applied Evolve block for a syncing node.
// In the case of an aggregator, this corresponds as the last fetched DA block height for forced inclused transactions.
// In the case of an aggregator, this corresponds as the last fetched DA block height for forced included transactions.
DAHeight uint64

// the latest AppHash we've received from calling abci.Commit()
Expand Down
Loading